invalid aspect ratio for screen icons in navbar

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/color-vision

GNU General Public License v3.0

1 stars 7 forks source link

invalid aspect ratio for screen icons in navbar #93

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

Screen icons for the navbar must have the same aspect ratio as either Screen.NAVBAR_ICON_SIZE or Screen.HOME_SCREEN_ICON_SIZE. See phetsims/joist#263 (comment). This sim does not, and fails when assertions are enabled.

aaronsamuel137 commented 9 years ago

Fixed. Assigning to @pixelzoom for review.

pixelzoom commented 9 years ago

@aaronsamuel137 I'm curious about this required a change to SCALE in FlashlightNode.

aaronsamuel137 commented 9 years ago

The flashlights in the RGB icons were extending outside of the background rectangle a little bit, so I scaled them a little smaller, otherwise the icon size gained a little height and lost the correct aspect ratio. I could have tried moving the flashlights closer too, but making them a little smaller didn't seem to look bad to me. What do you think?

pixelzoom commented 9 years ago

Sounds good, thanks for clarifying. Closing.