search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Revisit question of purple photons #96

Closed ariel-phet closed 6 years ago

ariel-phet commented 8 years ago

Some time ago @phetsims/bereaphysics mentioned that an alternative algorithm may exist that might better suit our mapping wavelenth to RGB

Hello Ariel With regards to the wavelength to RBG mapping, I was reading this http://www.scientificbulletin.upb.ro/rev_docs_arhiva/full49129.pdf I find that our current algorithm is almost the same except in the range 380 – 410 nm where it is significantly different. See figure 4 of the paper. I don't know if you want to leave it as is but if you want to change the algorithm, this would be a good reference to follow.

This is not a high priority, but it might be worth investigating at some point.

pixelzoom commented 6 years ago

If you're going to change the algorithm for mapping wavelength to RGB, that's a common-code issue. It would need to be addressed in scenery-phet VisibleColor. And it would affect all common UI components that use VisibleColor (WavelengthSlider, SpectrumNode), and all sims that use VisibleColor or one of those common components. That currently includes: beers-law-lab, concentration, bending-light, black-body-spectrum, color-vision, models-of-the-hydrogen-atom, molecules-and-light.

pixelzoom commented 6 years ago

@ariel-phet Do you mind if I move this issue to scenery-phet?

ariel-phet commented 6 years ago

@pixelzoom seems appropriate

pixelzoom commented 6 years ago

Moved this issue to https://github.com/phetsims/scenery-phet/issues/340.