phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Add visibility annotations #97

Closed aaronsamuel137 closed 8 years ago

aaronsamuel137 commented 8 years ago

In https://github.com/phetsims/tasks/issues/307 we decided that developers should add these to their own sims.

Consensus: we will leave it up to developers whether to keep things up to date (a) as we go (b) as the sim is republished or (c) before a developer leaves the team.

Since I am about to be leaving, I will try to get this done for color-vision before hand.

aaronsamuel137 commented 8 years ago

As part of these changes, I turned some attributes into vars that didn't really need to be attributes. However, now I am wondering whether these were needed for together somehow.

Here's the attributes I changed to vars:

In ColorVisionScreenView:

In RGBModel:

In GaussianWavelengthSlider:

Partly wondering this, because I see this in RGBSlider:

    // @public but only for together.js
    this.slider = hSlider;

Can @samreid or @jbphet comment, since they worked on instrumenting this sim.

samreid commented 8 years ago

No need to make things instance properties, tandem handles closure vars nicely. Also, color vision is already instrumented and seems to be working nicely as well. I removed the this.slider line and the sim runs without problems and I don't expect any together or phet-io issues.

samreid commented 8 years ago

Removed above, closing.