phetsims / concentration

"Concentration" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/concentration
GNU General Public License v3.0
1 stars 7 forks source link

Drag not canceled on faucets when liquid reaches bottom/top #10

Closed jonathanolson closed 11 years ago

jonathanolson commented 11 years ago

Reproduce:

  1. Start draining the fluid while pouring in fluid.
  2. Either have the drain rate faster (drain faucet will have issues once there is no fluid and it will refill), or have the drain rate slower (filling faucet will have issues once it is filled, and it will drain out).
jonathanolson commented 11 years ago

Same issue happens with no canceling of the dropper when the beaker fills up completely.

jonathanolson commented 11 years ago

Reset all button should also cancel interactions.

jonathanolson commented 11 years ago

http://www.colorado.edu/physics/phet/dev/html/concentration/1.0.0-rc.2/concentration_en.html

patricialoeblein commented 11 years ago

I don't know how to make more than one thing run at a time. Jon's steps seem to imply that you can fix the drain/faucet to run, and then you can operate another feature. Is there an operation I need to know about? I cannot reproduce this issue.

pixelzoom commented 11 years ago

@patricialoeblein: I realize it's nowhere in the ticket description. But this is a multi-touch issue, specific to tablets. You can (for example) open the faucet with one finger while shaking the shaker with another finger.

@jonathanolson: probably a good idea to include 'debug information' to prevent this type of confusion.

patricialoeblein commented 11 years ago

Thanks Chris, I am presently only testing on mouse systems, but I am scheduled to get a touch soon. I guess I better get some best practices for touch testing when that happens.

pixelzoom commented 11 years ago

The interaction with the Reset All button is a general issue, covered in https://github.com/phetsims/scenery/issues/109, so I'm going to ignore it here.

pixelzoom commented 11 years ago

Fix for faucets is in https://github.com/phetsims/scenery-phet/commit/e5f61f2a43809bebc592658e80163f77155b28e3

Fix for dropper button is in https://github.com/phetsims/beers-law-lab/commit/c276456268784b2e0522587897e78f787b9ce33e and https://github.com/phetsims/beers-law-lab/commit/da207e1e9f595d13bfa48c1cf30f82b7b5c43986

Closing.