search

phetsims / concentration

"Concentration" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/concentration
GNU General Public License v3.0
1 stars 7 forks source link

Performance gets a little slow on Safari if severely over saturated. #3

Closed jessegarrison closed 10 years ago

jessegarrison commented 10 years ago

Performance gets a little slow on Safari if you really over saturate, such as shaking the canister until it is completely out. Easiest to see with Potassium permanganate.

Troubleshooting information Name: Concentration URL: http://www.colorado.edu/physics/phet/dev/html/concentration/1.0.0-rc.1/concentration_en.html Version: 1.0.0-rc.1 Features missing: flexbox, touch User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/536.30.1 (KHTML, like Gecko) Version/6.0.5 Safari/536.30.1 Language: en-us Window: 1165x701 Pixel Ratio: 1/1

pixelzoom commented 10 years ago

The only thing happening in this situation is that the number of precipitate particles increases. The precipitate particles are drawn using scenery, while the solute particles coming out of the shaker are drawn directly to canvas (using scenery.CanvasNode). So the way to improve performance in this case is probably to draw the precipitate particles using scenery.CanvasNode. See beers-law-lab.PrecipitateNode.

Should we bother doing this?

pixelzoom commented 10 years ago

Performance in this situation doesn't look too bad to me (even on iPad). Animation of shaker particles gets a little chunky, but the shaker is still responsive.

pixelzoom commented 10 years ago

In https://github.com/phetsims/beers-law-lab/issues/48, we decided to live with better-looking precipitate at the expense of some performance. I'm assuming that applies here as well, so closing as "will not fix". And in this specific case, I think the performance is more than acceptable.