phetsims / concentration

"Concentration" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/concentration
GNU General Public License v3.0
1 stars 7 forks source link

Resetting an already resetted sim takes the soluteType to liquid then back to solid #39

Closed samreid closed 9 years ago

samreid commented 9 years ago

Resetting an already resetted sim takes the soluteType to liquid then back to solid.

{
  "messageIndex": 139,
  "eventType": "user",
  "componentID": "concentrationScreen.resetAllButton",
  "componentType": "ResetAllButton",
  "event": "fired",
  "time": 1428079706952,
  "children": [
    {
      "messageIndex": 140,
      "eventType": "model",
      "componentID": "concentrationScreen.soluteForm",
      "componentType": "Property",
      "event": "changed",
      "time": 1428079706952,
      "options": {
        "oldValue": "solid",
        "newValue": "liquid"
      }
    },
    {
      "messageIndex": 141,
      "eventType": "model",
      "componentID": "concentrationScreen.soluteForm",
      "componentType": "Property",
      "event": "changed",
      "time": 1428079706952,
      "options": {
        "oldValue": "liquid",
        "newValue": "solid"
      }
    }
  ]
}

This should be resolved for together integration within the next 2 weeks or so.

pixelzoom commented 9 years ago

This was broken by https://github.com/phetsims/beers-law-lab/issues/89. Fixed in https://github.com/phetsims/beers-law-lab/commit/6912d01264df3f6d149841cd58b72f38e8ad0fac. @samreid please verify and close.

samreid commented 9 years ago

I tested the arch output and it is fixed, and the change set looks good. Closing.