phetsims / concentration

"Concentration" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/concentration
GNU General Public License v3.0
1 stars 7 forks source link

[together.js] save/load the state of the shaker particles #41

Closed samreid closed 8 years ago

samreid commented 9 years ago

Currently the positions of the shaker particles are not being saved/loaded. They were still animated in mirror.html by running the concentration model clock and observing motion of the shaker. However, running the model clock in sims is not a good solution in general, and it has been disabled. So we need a way to transmit the shaker particle states. This should also solve a bug where reset all creates a single solute particle (when the shaker goes back to its initial location).

samreid commented 9 years ago

I made pretty good progress on the problem above--good enough to work for save/load and record/playback. It is still missing some details like the velocity of the particles and their orientation, though.

samreid commented 9 years ago

@jbphet anything else needed here?

pixelzoom commented 9 years ago

@jbphet is this done?

jbphet commented 9 years ago

I started taking a look at this yesterday and noticed a few issues, which @pixelzoom appears also to have noticed, since he logged https://github.com/phetsims/beers-law-lab/issues/102. So I think that this needs a bit more attention.

pixelzoom commented 9 years ago

Add https://github.com/phetsims/beers-law-lab/issues/103 and https://github.com/phetsims/beers-law-lab/issues/104 to the list of related issues, they also deal with deficiencies in support for particles.

samreid commented 9 years ago

@pixelzoom how much of this issue is critical for S2015R and how much can wait until we can dedicate some more time to together?

pixelzoom commented 9 years ago

I think we can punt on this for S2015R. Unlabeling.

pixelzoom commented 9 years ago

Back to @samreid. If you don't plan on working on this, feel free to unassign.

samreid commented 9 years ago

No plans to work on this at the moment.

ariel-phet commented 9 years ago

Assigning back to @jbphet (since it was originally his issue) now that S2015R has been removed

samreid commented 8 years ago

The remaining work is detailed in https://github.com/phetsims/beers-law-lab/issues/103, closing.