search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

review TODO items #102

Closed pixelzoom closed 5 years ago

pixelzoom commented 8 years ago

As part of #87, I added quite a few TODO items to the code. I was pulled off of curve-fitting before addressing them all. They should be reviewed and addressed.

SaurabhTotey commented 5 years ago

I have managed to address all of the TODOs in the repository. Currently, there is only one more TODO left which I myself put regarding the complexity of some calculations in BarometerX2Node. All other TODOs left in the code have been addressed and removed.

pixelzoom commented 5 years ago

👍 Nice job @SaurabhTotey.

SaurabhTotey commented 5 years ago

In 448d4af6095632c927ed19848741d44aeeaa9828, I managed to remove the last TODO which was one I placed about the complexity of BarometerNodeX2 calculations. As that was the last TODO, I am closing this issue now.