search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Convert from TWEEN to Twixt #112

Closed samreid closed 5 years ago

samreid commented 6 years ago

As discussed in https://github.com/phetsims/joist/issues/387#issuecomment-419600722, it would be nice to use Twixt instead of TWEEN. This sim has 1 occurrence of new TWEEN.Tween(...). Assigning to the responsible dev. After completing this issue, check if the hold on https://github.com/phetsims/joist/issues/387 can be removed (if this was the last "Convert from TWEEN to Twixt" issue).

SaurabhTotey commented 5 years ago

As of right now, I have changed the Point animations to use Twixt. However, a lot of the code regarding animations in that file can be simplified. I will mark this issue as ready to review once I simplify the logic in Point so that it is simpler and easier to read.

SaurabhTotey commented 5 years ago

Point has now been slightly cleaned up. As such, I believe this issue has been completed, and I am marking this as ready for review.