search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Should the X2 bar show that it extends further? #136

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/394 I noticed that X2 could get to be much larger than 100, and though the scale has an arrow to show this, the bar does not indicate that is going off the the scale. Should it somehow? shouldthisindicate

SaurabhTotey commented 5 years ago

I'll defer this design decision to @amanda-phet.

amanda-phet commented 5 years ago

That's a good question. I thought at one time the red bar went past 100 in that case, but I could be wrong. In either case, it doesn't really matter all that much. The point is, X^2 is really really big.

@SaurabhTotey if it's easy to make the red bar go past 100 when it's over 100, please do so. up to the base of the arrowhead seems fine to me.

SaurabhTotey commented 5 years ago

I have implemented that change in master.

x2barometerfill

Assigning to @amanda-phet to review.

amanda-phet commented 5 years ago

I think that looks reasonable.

Can you include this change in a new dev version for me to use tomorrow?

SaurabhTotey commented 5 years ago

Sure! This change is included in the dev.17 version at https://phet-dev.colorado.edu/html/curve-fitting/1.0.0-dev.17/phet/curve-fitting_en_phet.html.

amanda-phet commented 5 years ago

This looked good in interviews and students were focused on what made the meter increase/decrease, which is the goal. I think this change made sense so I'll close the issue.