search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Equation, but no line #139

Closed amanda-phet closed 5 years ago

amanda-phet commented 5 years ago

I noticed this in interviews and it seems very odd to me.

To reproduce:

  1. Place one point in the grid
  2. Turn on curve

There is a linear equation shown (which updates as the point moves), but there is no line being graphed (which is not consistent with the equation- an equation of a line).

I see three possible options as fixes: (1) The equation should read y = 0x + 0, which is technically still a line, but would be hidden behind the x-axis. (2) Graph the line reflected in the equation (3) Don't show an equation at all until there are 2+ points, but I'm not sure what we would put in that accordion box.

amanda-phet commented 5 years ago

Decision: Instead of an equation image

the accordion box will simply read "undefined"

SaurabhTotey commented 5 years ago

This has now been implemented in master. Assigning to @amanda-phet to review.

amanda-phet commented 5 years ago

Looks good to me.