search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Residual checkbox may not reset when reset all is used #161

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/423. It is possible to reset all but still have the residual checkbox even though it doesn't appear to be. Note, if you do not do step 5 bellow, residual resets fine. Steps to reproduce

  1. Refresh the sim page
  2. Put two points out
  3. Activate curve checkbox
  4. Activate residual checkbox
  5. Deactive curve checkbox
  6. Hit reset all
  7. Put two points out
  8. Activate curve checkbox
  9. Note that residual is still active

Visuals noresidualreset This is how a similar situation is handled in Wave Interference: WIhandle

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Curve Fitting‬ URL: https://phet-dev.colorado.edu/html/curve-fitting/1.0.0-dev.19/phet/curve-fitting_all_phet.html Version: 1.0.0-dev.19 2019-09-04 19:08:06 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.75 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
SaurabhTotey commented 5 years ago

I believe I fixed this in the previous commit in master. Assigning to @KatieWoe to review and sign off.

KatieWoe commented 5 years ago

Looks good on master