phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

Equation Pointer Area Dilated for mouse use #164

Closed KatieWoe closed 4 years ago

KatieWoe commented 5 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/431. Very minor issue. The pointer area for the equation's +/- button is dilated for both mouse and touch. Normally, only touch is dilated. This can be seen in the similar button for the X2 and r2 box.

Visuals inconsistentclickarea

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Curve Fitting‬ URL: https://phet-dev.colorado.edu/html/curve-fitting/1.0.0-rc.1/phet/curve-fitting_all_phet.html?showPointerAreas Version: 1.0.0-rc.1 2019-09-20 03:48:21 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
SaurabhTotey commented 5 years ago

I just removed the mouse dilation for the equation accordion box's expand/collapse button on master.

amanda-phet commented 5 years ago

@KatieWoe please feel free to review the change. I'm fine with the suggestion.

KatieWoe commented 5 years ago

Looks good on master

KatieWoe commented 4 years ago

Looks good in rc.5