search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

graphModelBounds not used consistently #88

Closed pixelzoom closed 5 years ago

pixelzoom commented 8 years ago

The model (CurveFittingModel) contains a field for the bounds of the graph:

42     this.graphModelBounds = CurveFittingConstants.GRAPH_MODEL_BOUNDS;

Elsewhere in the code, that field is sometimes used, and sometime clients just use CurveFittingConstants.GRAPH_MODEL_BOUNDS directly. So we should either (a) get rid of this field and use the constant everywhere, or (b) add a property Graph model element and use it everywhere.

SaurabhTotey commented 5 years ago

I don't think that this is an issue anymore. Marking as ready for review.