search

phetsims / curve-fitting

"Curve Fitting" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 3 forks source link

make control panels the same width #98

Closed pixelzoom closed 7 years ago

pixelzoom commented 8 years ago

This was broken during restructuring and cleanup in https://github.com/phetsims/curve-fitting/issues/87. I was pulled off of curve-fitting before addressing it.

pixelzoom commented 8 years ago

This concerns the panels created in type ControlPanel, which currently looks like this:

screenshot_13

memo330179 commented 8 years ago

I took care of this by making the PANEL_MAX_WIDTH and PANEL_MIN_WIDTH the same size. This allows the panels to all take the same size and always be the same relative size no matter the size of the sim.

pixelzoom commented 7 years ago

@memo330179 Is this ready for me to review, or is there additional work to be done?

memo330179 commented 7 years ago

I think this one is ready for review.

pixelzoom commented 7 years ago

Looks good and passes stringTest. Closing.