search

phetsims / decaf

PhET Java Simulations converted to HTML5 using CheerpJ
1 stars 0 forks source link

Try using the window.innerWidth and innerHeight for minimum initial frame size #68

Open samreid opened 4 years ago

samreid commented 4 years ago

Try using the window.innerWidth and innerHeight for minimum initial frame size.

samreid commented 4 years ago

On iPad, the getAvailableRectangle seems incorrect--may not be accounting for tabs or other parts at the top of mobile safari.

samreid commented 4 years ago

It currently looks like this on the ipad:

image

samreid commented 4 years ago

If i use the window.innerWidth and height, it starts up like this on iPad:

image

samreid commented 4 years ago

I published https://phet-dev.colorado.edu/decaf/faraday/1.0.0-dev.20/index.html with

SVN 75120 decaf 9c3457c4507add2c4a9c3cd67b38d6954fbadc87 chipper 7fabe653c04e70c1c5c2953b0b2d9cc45d2c9c87

@KatieWoe can you please test?

samreid commented 4 years ago

@kathy-phet and @samreid noticed that dev.20 cuts off the bottom of the sim on iPhone landscape.

In https://github.com/phetsims/QA/issues/494#issuecomment-615419724 @kathy-phet said:

@samreid - I am still having some loading cut off when loading in landscape on iPhone in dev.20. Can you work locally with your devices to see if you can debug to something that does not cut off the bottom on load?

@kathy-phet does this warrant investigation before publication?

kathy-phet commented 4 years ago

If it works on the iPad - let's publish. We can tweak later if we figure something out.

samreid commented 4 years ago

@KatieWoe reported it loaded properly (could see the bottom of the reset all button) on her test iPad.

samreid commented 4 years ago

Reducing priority based on the past 2 comments.