Closed DianaTavares closed 4 months ago
This screen will be the first in buoyancy and Buoyancy: Basics, and in both, the name of the screen is "Compare"
I would like to clarify before starting. Does this mean the Compare screen will replace the the "intro" screen in Buoyancy?
Current screens in Buoyancy: Intro, Explore, Lab, Shapes, Applications
After this change: Compare, Explore, Lab, Shapes, Applications
And we will delete the code for Intro? Or will this be a 6th screen in Buoyancy? (I didn't think so but wanted to double check). Please clarify.
Yes, this is the change for buoyancy:
Compare, Explore, Lab, Shapes, Applications
Intro will be replaced by Compare.
Working on this now
Some progress but I'm not in love with this patch. I'll come back tomorrow
I believe all of this is done besides the "Density Comparison" rename that will occur in a different issue. @DianaTavares please review.
@samreid can you please spot check this commit:
https://github.com/phetsims/density-buoyancy-common/commit/07199490424177a9941f2ca9989e55ba62d91c6e
From the view (design) side, it looks amazing! thanks.
I don't love how the Contact force is moving as crazy while I manipulate the slider. The other 2 forces are amazing, weight is constant, and the buoyancy force increases/decreases slowly as the block is submerged or moving out of the pool, but contact, goes up and down as crazy (I hope this is something see can do!)
I see that the same happens with the numbers in the scale, but that isn't as distracting as an arrow going up and down.
@AgustinVallejo are we using the blend algorithm on that displayed contact force value?
This patch adds more blending for the value and smooths out that displayed value. It isn't perfectly smooth though and it adds latency to reach the value
We should probably discuss and tune this during standup.
@samreid I applied the patch and very much like this solution. Vote for adding it!
[x] The initial state of the blocks in each scene are:
Same mass: A1: Brick (m=4kg, V=2L), B1: Wood (m=4kg, V=10L)
Same volume: A2: Brick (m=10Kg), V=5L), B2: Wood (m=2kg, V=5L)
Same Density: A3: Wood (m=2kg, V=10L), B3: Wood (m=4kg, V=10L)
[x] Once the user moves the Mass/Volume/Density (depending on the scene selected), the blocks' colors change to the Yellow and Blue that B:B has. The blocks maintain that color, no matter that the user moves the control to the initial state values. The only way to get again the wood/brick is to restart the sim.
[x] See https://github.com/phetsims/density-buoyancy-common/issues/156 Change the name of the “Density” panel to “Density Comparison” panel:
[x] #157