search

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

Add vector ZoomButtonGroup to B:B like we have in full sim #205

Closed samreid closed 3 months ago

samreid commented 3 months ago

From today's design meeting:

It’s possible for the vectors to go off-screen. Should we add zoom controls?

Should zoom controls go behind a Preference? No, don’t need a Preference for this. Vectors are off by default, which is sufficient.

Consensus: Add vector ZoomButtonGroup to B:B like we have in full sim

samreid commented 3 months ago

The request was to add this feature to B:B. However, adding it in B:B adds it in the Compare screen, which is shared in Buoyancy, so Buoyancy will also get this feature in the compare screen. In the design meeting, it sounded like was no problematic so perhaps this is OK. After I commit I will double check with @DianaTavares

samreid commented 3 months ago

Fixed, please review on phettest and please close if ok.

DianaTavares commented 3 months ago

looks amazing! thanks!