search

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

BlocksValueControlPanel issues regarding tandem/ToggleNode/PhetioControlledVisibilityProperty #216

Closed samreid closed 3 months ago

samreid commented 3 months ago

@zepumph and I saw that BlocksValueControlPanel probably should be a ToggleNode. That may clean up its visibleProperty instrumentation. It needs to have a visibleProperty instrumented. Check if PhetioControlledVisibilityProperty is needed or can be adjusted like in https://github.com/phetsims/density-buoyancy-common/issues/207

samreid commented 3 months ago

Fixed. This allowed us to delete PhetioControlledVisibilityProperty since it was the only usage. We will review the studio tree in https://github.com/phetsims/buoyancy/issues/51. Closing.