phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

Updates to `numberDisplay` instrumentation #239

Open arouinfar opened 2 days ago

arouinfar commented 2 days ago

For https://github.com/phetsims/buoyancy/issues/51

There are a few places where numberDisplay.visibleProperty should be instrumented, but is missing. Hiding NumberDisplay allows instructional designers to create more qualitative lessons, which we should support.

Let's instrument AND feature numberDisplay.visibleProperty for

There are also a few places where the NumberDisplay doesn't need to be instrumented at all, and is a bit buggy.

Let's uninstrument the entire numberDisplay for the height/width controls on Shapes.

Assigning to the dev team.