search

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

Mystery fluids should be called 'Fluid A' rather than 'Density A' #248

Closed arouinfar closed 2 months ago

arouinfar commented 3 months ago

Related to https://github.com/phetsims/buoyancy/issues/51

During today's design meeting with @DianaTavares @AgustinVallejo @samreid @zepumph, we decided to call the mystery fluids 'Fluid A', etc. They are currently named 'Density A' etc.

image image

We'll need to change string in the ListBox, associated phetioID, and string key to use the 'fluid' language.

AgustinVallejo commented 3 months ago

Pushing this change. What's left is changing the string keys, as I would like to do it with a more experienced developer to avoid translation mishaps.

AgustinVallejo commented 3 months ago

Moving that string key part to https://github.com/phetsims/density-buoyancy-common/issues/183. Assigning back to @arouinfar for review.

arouinfar commented 2 months ago

Thanks @AgustinVallejo! Looks good in main, closing.