Closed samreid closed 1 month ago
Working on this now.
Ok. Here is an updated list, organized:
I fixed everything, except one that I added a TODO to investigate over in https://github.com/phetsims/density-buoyancy-common/issues/256.
I do still think this would be good to do in B:B and Density, but I don't have time to do this now.
I believe that the above work fixed ~10 bugs from previously designed phet-io APi.
We already handled this for density by fixing the migration wrapper over in #274.
I tool another glance through buoyancy-basics, and all is good.
After merging the staticMaterials branch, we want to understand and correct for all of the API changes in
For instance, here are the buoyancy issues we detected with API comparison, we annotated some of them near the top.
Here is the sha with the legacy API files from main that we should endeavor to understand: https://github.com/phetsims/phet-io-sim-specific/commit/4049c3101e5ecf0bf8ae225b15c56ac8eb2c3e17