Create a directory js/common/model/mass

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations

GNU General Public License v3.0

0 stars 2 forks source link

Create a directory js/common/model/mass #299

Closed samreid closed 1 month ago

samreid commented 1 month ago

From https://github.com/phetsims/density-buoyancy-common/issues/123, it is recommended to create a subdirectory js/common/model/mass which would include at least the 12 subtypes of Mass.ts:

Mass
Cube
Cuboid
Ellipsoid
etc

This will help organize and clean the common model directory

[ ] likewise, in common/view, create a subdirectory for view files like ConeView, 'MeasurableMassView`, etc.

samreid commented 1 month ago

Or if many of these shapes are only used in the shapes screen, they could move there.

samreid commented 1 month ago

After moving out the "shapes" screen ones, the number of remaining Mass subclasses in common/ is small, so does not warrant another directory. Closing.

phet-dev commented 1 month ago

Reopening because there is a TODO marked for this issue.