Closed Nancy-Salpepi closed 1 month ago
I'll take a look
Fixed in this patch. @zepumph can you please review? You can commit the patch if all is well:
@zepumph and I fixed this in the commits. @Nancy-Salpepi can you please test on phettest?
I can still reproduce on main using the original steps in https://github.com/phetsims/density-buoyancy-common/issues/354#issue-2481474284
2 other examples:
applicationModeRadioButtonGroup
select boat and then switch back to bottleshift
+ tab
back to the bottle --message is there again__
shapeComboBox
and select a different shapeshift
+ tab
back to Object A --message is there againSome observations:
The problem for the Applications screen is that protected override getMassViewFromMass( mass: Mass ): MassView {
is called from the super constructor. Hence, at runtime this.bottleView
is assigned at this point. However, then the sub-constructor is called which had this code:
private bottleView: BottleView | null = null;
private boatView: BoatView | null = null;
which nulls it back out. Hence the BottleView and BoatView are created twice.
Discussed during standup today, and we think this is a good general design question to ask about grab drag interaction. The general question is, "how much does the user need to see the grab cue?"
Let's make a common code issue and ask some experts
We discussed at a designers meeting with JG SR MK in attendance as well. We noted that it isn't necessarily automatic that cueing grab for a block would translate to cueing grab for the scale. Furthermore, more cueing is better than less cueing, so long as it isn't too distracting or obscuring.
We decided to try out the following:
This bug will be designed and sorted out over in https://github.com/phetsims/density-buoyancy-common/issues/368.
Design has been solidified over in https://github.com/phetsims/density-buoyancy-common/issues/368. Closing
Test device MacBook Air M1 chip
Operating System 14.6.1
Browser Safari 17.6
Problem description For https://github.com/phetsims/qa/issues/1136, the ‘space to grab or release’ message resets every time I switch scenes.
From Slack:
Steps to reproduce Here is an example:
Visuals
https://github.com/user-attachments/assets/7583fd88-c59a-4f50-87f4-2f53055ca7ea