search

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

Changes to examples.md #371

Closed Nancy-Salpepi closed 1 month ago

Nancy-Salpepi commented 1 month ago

For https://github.com/phetsims/qa/issues/1136

For Buoyancy Basics under Reorder the materials in the ComboBox change buoyancyBasics.exploreScreen.view.fluidDensityPanel.comboBox.listBox

to buoyancyBasics.exploreScreen.view.fluidPanel.comboBox.listBox

Any further changes/suggestions will also be added to this issue.

Nancy-Salpepi commented 1 month ago

For Density, since the Volume Units are the only thing in the Simulation Tab of the Preferences Menu I would suggest changing the visible property of the the tab rather than the visible property of the volumeUnits Control.

Change: density.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesPanels.simulationPreferencesPanel.volumeUnitsControl.visibleProperty

To: density.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesTabs.simulationTab.visibleProperty

zepumph commented 1 month ago
arouinfar commented 1 month ago

Thanks @Nancy-Salpepi! I made the suggested changes in the above commits.

To address https://github.com/phetsims/density-buoyancy-common/issues/371#issuecomment-2321827122, I added this to the Density and Buoyancy under the 'Specify block density' section:

The Custom material behaves differently, allowing independent control of mass and volume. Its densityProperty is not a constant, and can be changed by subsequent interaction with the mass, volume, or material controls. For this reason, we recommend you first set the material to ‘Custom’ before modifying its density.

I did not add this information to Buoyancy: Basics, because customMaterial.densityProperty behaves a bit differently since it is tied to the Density slider.

Closing!