search

phetsims / density-buoyancy-common

Common code for the Density and Buoyancy simulations
GNU General Public License v3.0
0 stars 2 forks source link

Add value for ScaleHeightSliderOptions.sliderOptions.accessibleName. #424

Open pixelzoom opened 2 hours ago

pixelzoom commented 2 hours ago

Related to https://github.com/phetsims/sun/issues/904#issuecomment-2436018783, where we decided to delete Tandem.toAccessibleName... I will remove the 1 usage that is in this repo, which is used to set the default for ScaleHeightSliderOptions.sliderOptions.accessibleName in PoolScaleHeightControl.ts.

pixelzoom commented 2 hours ago

Over to @zepumph for next steps -- which may be to unassign/defer for now.

PSA: You may wish to wait until https://github.com/phetsims/scenery-phet/issues/878 is addressed before doing work on this. Setting sliderOptions.accessibleName is a workaround, and not the future for NumberControl.