phetsims / density

"Density" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 6 forks source link

Updates to phetioDocumentation #126

Closed arouinfar closed 2 years ago

arouinfar commented 2 years ago

In #99 I discovered that there were a few properties that would benefit from phetioDocumentation.

@jonathanolson here is the suggested text, please feel free to edit as necessary.

jonathanolson commented 2 years ago

Implemented, can you verify?

arouinfar commented 2 years ago

@jonathanolson looks pretty good. I wrote the phetioDocumentation with the blocks in mind, but forgot about scale.massProperty and scale.volumeProperty. Would it be possible to remove the phetioDocumentation for the scale? Since the scale isn't adjustable, I think the phetioID provides a sufficient enough description of these properties.

jonathanolson commented 2 years ago

I believe that should be handled above, can you verify?

arouinfar commented 2 years ago

Looks good, thanks @jonathanolson!