phetsims / density

"Density" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 6 forks source link

Primary/secondary mass labels have inappropriate maxWidth #149

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

Discovered when reviewing dynamic layout/strings in https://github.com/phetsims/density/issues/145.

The primary/secondary masses on the Intro screen do not gracefully handle dynamic strings.

image

Looks like these labels need a more appropriate maxWidth so they don't escape the bounds of the background rectangle. @jonathanolson can you reduce the maxWidth so that the string remains within bounds?

arouinfar commented 1 year ago

Tagging for #150

arouinfar commented 1 year ago

The behavior on master seems to be okay now, so I'm going to close.

image

If I see the issue happening again, I'll reopen.