Closed arouinfar closed 1 year ago
Added units to the intermediate Properties above.
Discussed with @jonathanolson and @DianaTavares
The intermediary properties are necessary to the internal workings of the sim, so this is a big ask. Instead, we decided to consistently name these properties, numberControlMassProperty
and numberControlVolumeProperty
and @jonathanolson has already added units.
Renaming done above, can you verify?
Also, should I uninstrument those?
@jonathanolson the updated names and units look good, thanks.
Also, should I uninstrument those?
From our discussion, it sounded like they were necessary to the internal workings of the sim. Rather than uninstrument, we decided to consistently name these properties and provide them with the correct units.
Closing.
For #150
On the Intro Screen, the Mass NumberControl has an internal
massNumberProperty
. I decided to unfeature it in #137 because It is identical to themassProperty
found in the model. The only usage ofmassNumberProperty
seems to be a dependency for thenumberDisplay.valueText
.I don't think
massNumberProperty
ormassNumberControl.numberDisplay.valueText
add any real value. We use the same mass units in the model and the view. Can these be uninstrumented @jonathanolson?Similarly, the Volume NumberControl has an associated
numberControlVolumeProperty
which appears to be the volume in liters, though its units are null. The only usage ofnumberControlVolumeProperty
that I can find is a dependency of the associatednumberDisplay.valueText
. However, this seems like an odd way to give clients access to the volume in liters. The method indensity.compareScreen.view.volumeNumberControl.numberDisplay.valueText.stringProperty
is preferable.@jonathanolson can we instrument
numberControlVolumeProperty
and use the Compare Screen method to display the NumberDisplay contents?