Open KatieWoe opened 1 year ago
This looks like https://github.com/phetsims/density/issues/133 is not solved... the Mystery screen scale's initial position depends on the invisible barrier.
So we still have "initial data needs to be different based on the user's screen". @samreid thoughts?
@zepumph and I discussed this with @jonathanolson and we have a workaround for phetioAPICompare that will work ok for RC. For a longer-term solution, we may need to introduce a new PhetioObject metadata key that can be used like this:
Adding a metadata key is not trivial, so I don't know if it should be done for this RC or not. Also, we try to minimize those keys since we have a lot of PhetioObjects and don't want too much memory burden.
Should be handled with the above workaround.
This should be fixed generally by https://github.com/phetsims/phet-io/issues/1951
Seems like the solution here is to create an html page with the sim in an iframe with a constant size. This can be used for api-comparison AND for generation. This would make the screen size constant across all modes.
We punted on this for now, because it wouldn't be a general enough fix.
I'd like to do some investigation about this for Buoyancy because we will have to add to this workaround. If we lock in api-generation browser dimensions like mentioned in https://github.com/phetsims/aqua/issues/200 that may help remove this workaround.