search

phetsims / density

"Density" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 6 forks source link

Items in densityAccordionBox can be off-center and possibly overlap #162

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.3.1

Browser Safari 16.3

Problem description For https://github.com/phetsims/qa/issues/930, on the Intro Screen when in locales other than English, the items in the density accordion box aren't always centered between the markers. This is easily reproduced using ?stringTest=dynamic.

Steps to reproduce

  1. Add ?stringTest=dynamic to url
  2. On the intro screen, press right arrow once and then press the down arrow once

Visuals

Screenshot 2023-04-19 at 5 00 07 PM Screenshot 2023-04-19 at 5 00 14 PM
jonathanolson commented 1 year ago

Should be fixed with the commit above, can you verify?

Nancy-Salpepi commented 1 year ago

This is looking good now! Closing.

stemilymill commented 1 year ago

https://github.com/phetsims/qa/issues/942

There isn't any overlapping or serious issues, but in some languages the words for 'steel' and 'copper' can sometimes be so close together they look like one word. Should there be slightly more separation?

example Tamil on windows

text boundaries tamil

example Georgian on windows

text boundaries georgian