phetsims / density

"Density" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 6 forks source link

Possible for blocksRadioButtonGroup to be very close to Reset All button #168

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.3.1

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/930, in Studio on the Intro Screen: The massNumberControl.visibleProperty and volumeNumberControl.visibleProperty are PhET-iO featured. Setting both properties to false for Block A causes the blocksRadioButtonGroup to shift right in order to stay aligned with the Block A control panel.

Steps to reproduce

  1. In studio set view.blockAControlPanel.massNumberControl.visibleProperty to false
  2. Set view.blockAControlPanel.volumeNumberControl.visibleProperty to false

EDIT: This also happens if I set massNumberControl.slider.visibleProperty and volumeNumberControl.slider.visibleProperty to false instead of the steps above.

Visuals

Screenshot 2023-04-26 at 1 29 59 PM
Nancy-Salpepi commented 1 year ago

In some locales (ex. Ku, Bo) in can look like this:

Screenshot 2023-04-26 at 1 39 20 PM Screenshot 2023-04-26 at 5 44 30 PM
jonathanolson commented 1 year ago

This looks like a consequence of the constraints (keep the button group bottom-aligned with the bottom of the pool, left-aligned with the upper-right content). @arouinfar or @DianaTavares, thoughts on if anything should be done about this?

arouinfar commented 1 year ago

How about we remove the requirement to keep it left-aligned with the Blocks panel? Since the buttons are in close proximity to the pool, and the pool size shouldn't change, it seems safer to maintain bottom-alignment with the pool. Here's what it would look like with a narrow Blocks Panel:

image

@DianaTavares does that seem reasonable to you?

DianaTavares commented 1 year ago

Yes, it is better if the blocksRadioButtonsGroup are not aligned with the up panel. Less movement if they are only in alignment with the pool

jonathanolson commented 1 year ago

Implemented in master, how this this look/feel?

arouinfar commented 1 year ago

Looks great, thanks @jonathanolson!