Closed Nancy-Salpepi closed 1 year ago
In some locales (ex. Ku, Bo) in can look like this:
This looks like a consequence of the constraints (keep the button group bottom-aligned with the bottom of the pool, left-aligned with the upper-right content). @arouinfar or @DianaTavares, thoughts on if anything should be done about this?
How about we remove the requirement to keep it left-aligned with the Blocks panel? Since the buttons are in close proximity to the pool, and the pool size shouldn't change, it seems safer to maintain bottom-alignment with the pool. Here's what it would look like with a narrow Blocks Panel:
@DianaTavares does that seem reasonable to you?
Yes, it is better if the blocksRadioButtonsGroup are not aligned with the up panel. Less movement if they are only in alignment with the pool
Implemented in master, how this this look/feel?
Looks great, thanks @jonathanolson!
Test device MacBook Air M1 chip
Operating System 13.3.1
Browser Safari
Problem description For https://github.com/phetsims/qa/issues/930, in Studio on the Intro Screen: The
massNumberControl.visibleProperty
andvolumeNumberControl.visibleProperty
are PhET-iO featured. Setting both properties to false for Block A causes theblocksRadioButtonGroup
to shift right in order to stay aligned with the Block A control panel.Steps to reproduce
view.blockAControlPanel.massNumberControl.visibleProperty
to falseview.blockAControlPanel.volumeNumberControl.visibleProperty
to falseEDIT: This also happens if I set
massNumberControl.slider.visibleProperty
andvolumeNumberControl.slider.visibleProperty
to false instead of the steps above.Visuals