search

phetsims / density

"Density" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 6 forks source link

Weighing bug #194

Closed lesha724 closed 3 months ago

lesha724 commented 6 months ago

Hello, I have bug with weight in mystery section:

image image image image image

zepumph commented 6 months ago

Thanks for the submission. I will take a look and bring it to my team.

lesha724 commented 6 months ago

@zepumph, Thanks

zepumph commented 6 months ago

This may be related to https://github.com/phetsims/buoyancy/issues/64

zepumph commented 5 months ago

I was able to reproduce the problem. I can see that the value can change depending on how I drop the top block onto the bottom one. I sometimes got a value like: 19.704819877536927, and other times, 19.70501456941877. I will see if it is just a dividing error slop, or if it is in part from some of the tolerances built into the P2 physics engine. If it is the latter, we may decide not to change this, since values for stiffness/relaxation/etc have been fine tuned to fix many other bugs (see here).

AgustinVallejo commented 3 months ago

We're experimenting with a solution for https://github.com/phetsims/buoyancy/issues/64 that might affect this. On hold

AgustinVallejo commented 3 months ago

https://github.com/phetsims/buoyancy/issues/167 This fix made this issue dissappear as well. Closing

zepumph commented 3 months ago

This bug was reported by an outside party (thank you for doing that). It isn't clear that we are republishing this sim with the publication of buoyancy, and if not this is still a bug in production. Let's keep this open until confirming that we are planning to republish density also. Otherwise we may consider an MR.