Closed KatieWoe closed 4 months ago
Here is a working patch that expands the definition of "compatible" parameter values from "has to be equal" to "new versions can add new members". This is working well in the density wrapper. I wrote 2 nit-picky TODOs that would be good to check in on. @zepumph can you please take next steps?
I love this solution. Thanks so much. I went down a bit of a rabbit hole making sure everything was working as expected. MapIO
wasn't ordered, so I fixed that. I also wrote unit tests to help boost my confidence. Anything more you want to talk about here?
@zepumph and I reviewed CT and it was very nice. We made another improvement, re-tested and it seems good. Closing.
density : migration : 1.1->main : assert http://128.138.93.172/continuous-testing/ct-snapshots/1713961184254/phet-io-wrappers/migration/?sim=density&oldVersion=1.1&phetioMigrationReport=assert&locales=*&phetioDebug=true&phetioWrapperDebug=true&fuzz&migrationRate=5000&&wrapperContinuousTest=%7B%22test%22%3A%5B%22density%22%2C%22migration%22%2C%221.1-%3Emain%22%2C%22assert%22%5D%2C%22snapshotName%22%3A%22snapshot-1713961184254%22%2C%22timestamp%22%3A1713961971822%7D Assertion failed: MigrationReport problem: stateSchemaIncompatible