search

phetsims / diffusion

"Diffusion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
3 stars 5 forks source link

Diffusion creates empty content for the Preferences "General" tab. #8

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

After Options where folded into Preferences for https://github.com/phetsims/joist/issues/837 ...

@zepumph reported in https://github.com/phetsims/joist/issues/837#issuecomment-1224271134:

deleted ProjectorModeCheckbox above. The only weird thing is that diffusion still creates a GasProperties preferences Node even though it has no content for it. Since it is in a suite. I thought that was better, in case a new option is added to that sime that should apply to all three sims (gas-properties, diffusion, and gases-intro).

This should be addressed. Diffusion should not create content for the Preferences General tab.

pixelzoom commented 2 years ago

Addressed in the above commits. Diffusion no longer created empty content for the General tab of the Preferences dialog. Screenshot below. Closing.

screenshot_1816