search

phetsims / dot

A math library with a focus on mutable and immutable linear algebra for 2D and 3D applications.
http://scenerystack.org/
MIT License
13 stars 6 forks source link

Eliminate Utils.isInteger #104

Closed samreid closed 3 years ago

samreid commented 3 years ago

Utils.isInteger was written to support IE since IE doesn't have Number.isInteger. Now that we no longer support IE, we can eliminate Utils.isInteger and use Number.isInteger.

See also https://github.com/phetsims/tasks/issues/1037 and https://github.com/phetsims/tasks/issues/1039

samreid commented 3 years ago

Pushed and ready for review. Most conversions were straightforward Utils.isInteger=>Number.isInteger, and in some cases removing the Utils import. Dot had a different commit because it also removed the function, and updated documentation. @ariel-phet can you please request a reviewer?

ariel-phet commented 3 years ago

@chrisklus is on the case

chrisklus commented 3 years ago

Commits look good, updated docs/Utils look good, and I can't find any missed usages. Thanks @samreid, back to you.

samreid commented 3 years ago

Thanks for the review, closing.