search

phetsims / dot

A math library with a focus on mutable and immutable linear algebra for 2D and 3D applications.
http://scenerystack.org/
MIT License
13 stars 6 forks source link

address TODOs #95

Closed pixelzoom closed 1 year ago

pixelzoom commented 5 years ago

Several TODOs and dead code in Quaternion.js with no associated GitHub issue:

6 * TODO: convert from JME-style parametrization into classical mathematical description?
96    // TODO: note why this is the case? product noted everywhere is the other one mentioned!
      // mathematica-style
//        return new Quaternion(
//                this.x * quat.x - this.y * quat.y - this.z * quat.z - this.w * quat.w,
//                this.x * quat.y + this.y * quat.x + this.z * quat.w - this.w * quat.z,
//                this.x * quat.z - this.y * quat.w + this.z * quat.x + this.w * quat.y,
//                this.x * quat.w + this.y * quat.z - this.z * quat.y + this.w * quat.x
//        );
138      // TODO: optimization?
pixelzoom commented 5 years ago

This is apparently a pervasive problem in dot. Moving to https://github.com/phetsims/dot/issues/96.

phet-dev commented 1 year ago

Reopening because there is a TODO marked for this issue.

marlitas commented 1 year ago

This never got closed. Ironically, because of a TODO issue. I committed a fix that I accidentally linked to #96. Closing.