Improve Transform3 matrix validation

phetsims / dot

A math library with a focus on mutable and immutable linear algebra for 2D and 3D applications.

http://scenerystack.org/

MIT License

13 stars 6 forks source link

Closed samreid closed 4 years ago

samreid commented 4 years ago

While working on https://github.com/phetsims/circuit-construction-kit-common/issues/536 and https://github.com/phetsims/circuit-construction-kit-common/issues/535, I noticed that Transform3 uses a rule for validating its matrices that is incompatible with the strategy used in ModelViewTransform2. It would be nice to use an approach that can be overriden in ModelViewTransform2. I'll commit then reassign to @jonathanolson for review.

samreid commented 4 years ago

Fixed in the preceding commits. Also, I remove an extraneous assertion in setMatrix since it immediately calls invalidate with the same value.

@jonathanolson do you mind double checking? It should be quick.

jonathanolson commented 4 years ago

That looks nice to me, thanks!