Automated Testing Build Error (9/28/2016 9:30 AM)

phetsims / energy-forms-and-changes

"Energy Forms And Changes" is an educational simulation in HTML5, by PhET Interactive Simulations.

MIT License

5 stars 5 forks source link

Automated Testing Build Error (9/28/2016 9:30 AM) #28

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

Running "eslint:allFiles" (eslint) task

/home/mendeleev/git/energy-forms-and-changes/js/energy-systems/model/SolarPanel.js
  220:11  error  'energySinceLastChunk' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

Warning: Task "eslint:allFiles" failed. Use --force to continue.

andrewadare commented 8 years ago

There are some weird things going on in my working copies. I didn't have this lint error, but then re-installed ~~npm~~ node_modules in energy-forms-and-changes.

The linter then threw the error shown above. Once I fixed it, the sim now fails to load with:

Path.js?bust=1475094932461:95 Uncaught TypeError: this._shape.isImmutable is not a function

More investigation needed...

andrewadare commented 8 years ago

This is fixed now.