Graph potential and kinetic bar off.

phetsims / energy-skate-park-basics

"Energy Skate Park: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/energy-skate-park-basics

GNU General Public License v3.0

2 stars 9 forks source link

Graph potential and kinetic bar off. #447

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

I found this behavior in the graph when changing the mass of the skater in ESPB. Potential bar looks buggy and only shows up slightly, kinetic doesn't show up at all. You have to zoom in quite a lot to even see this much, even though there is a lot of movement. To reproduce, start skater with friction and wait until they are under the "0" line. Then remove friction. Make skater as light as possible. Observe graph. Found during https://github.com/phetsims/QA/issues/226#issuecomment-445972634 energy

samreid commented 5 years ago

Co-assigning @jessegreenberg in case I need help on this one.

jessegreenberg commented 5 years ago

The graph is actually reading correctly for the amount of mass. The problem for energy-skate-park-basics is that it started using the mass range of energy-skate-park after phetsims/energy-skate-park#6. With tiny mass, PE and KE are not visible at all with these graph scales.

The above commits fix this issue. capture

Also, Ill make the initial reference height zero again, I just did that to see negative values in the bar graph.

jessegreenberg commented 5 years ago

Thanks @KatieWoe, closing this issue.