phetsims / energy-skate-park

"Energy Skate Park" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
2 stars 11 forks source link

Missing tandemName for 'custom' combo box item #341

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

Noted while working on https://github.com/phetsims/sun/issues/768 ...

PhysicalComboBox specifies tandemName for most items:

    // {[].ComboBoxItem}
    const itemList = [];
    labelValueList.forEach( entry => {
      itemList.push( {
        value: entry.value,
        node: new Text( entry.label, EnergySkateParkConstants.COMBO_BOX_ITEM_OPTIONS ),
        tandemName: entry.tandemName
      } );
    } );

... but does not specifiy tandemName for 'custom':

    if ( options.supportCustom ) {
      itemList.push( {
        value: null,
        node: new Text( controlsGravityCustomString, EnergySkateParkConstants.COMBO_BOX_ITEM_OPTIONS )
      } );
    }

Is this an oversight?

jessegreenberg commented 2 years ago

Thanks, yes I assume so. I added a tandemName for the "Custom" item and verified it showed up in studio.