Closed jessegreenberg closed 1 year ago
@jessegreenberg @AgustinVallejo @marlitas
Can we move the Region and Culture control so that it appears before the locale selections? It's easy to overlook when it's at the bottom of the dialog.
That looks like a me fix! I'll put it on the docket for today or tomorrow. More than likely can get to it today.
Thanks @marlitas!
Other remaining design questions:
Neither of these issues should block dev testing, but they should be finalized before we go to RC.
@arouinfar That switch has been made and is pushed up to master. Let me know if there's any feedback or additional changes.
Looks great, thanks @marlitas!
I'll leave this open and self-assigned since there are still some open design questions.
Regarding the names, here are some options
I think "Conservative" is too loaded of a term - it could mean political, religious, etc. We are focused here just on clothing specifically. What do you think, @arouinfar? Should we ask our PhET Fellows in Arabic-speaking Africa?
@arouinfar -
Discussed with @kathy-phet and we decided:
@jessegreenberg @AgustinVallejo @marlitas let's update the language to "Africa (Modest)" before RC. The term may change again before publication, but a string change should be a fairly safe cherry-pick later.
@jessegreenberg and @AgustinVallejo, let me know if you need any help or changes on the preferences side for this.
Names have been changed!
Thanks @AgustinVallejo looks good. This issue no longer blocks RC testing.
Here's what it currently looks like:
I'll leave this self-assigned, and report back when there are updates from Sola and Zach.
@arouinfar I got feedback from four PhET fellows, who all confirmed that "Africa Modest" is better than "Africa conservative."
Hi, @arouinfar works with most people. It is popular across the fashion industry, religion, and geography.
Thanks @zamb6873 @solaolateju! Let's proceed with "Africa (Modest)", closing.
From https://github.com/phetsims/joist/issues/814, but this issue is just for the skater character control.