phetsims / energy-skate-park

"Energy Skate Park" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
2 stars 11 forks source link

Add the UI for swapping out skater images for localization work #345

Closed jessegreenberg closed 1 year ago

jessegreenberg commented 2 years ago

From https://github.com/phetsims/joist/issues/814, but this issue is just for the skater character control.

arouinfar commented 1 year ago

@jessegreenberg @AgustinVallejo @marlitas

Can we move the Region and Culture control so that it appears before the locale selections? It's easy to overlook when it's at the bottom of the dialog.

image
marlitas commented 1 year ago

That looks like a me fix! I'll put it on the docket for today or tomorrow. More than likely can get to it today.

arouinfar commented 1 year ago

Thanks @marlitas!

Other remaining design questions:

Neither of these issues should block dev testing, but they should be finalized before we go to RC.

marlitas commented 1 year ago

@arouinfar That switch has been made and is pushed up to master. Let me know if there's any feedback or additional changes.

arouinfar commented 1 year ago

Looks great, thanks @marlitas!

I'll leave this open and self-assigned since there are still some open design questions.

kathy-phet commented 1 year ago

Regarding the names, here are some options

I think "Conservative" is too loaded of a term - it could mean political, religious, etc. We are focused here just on clothing specifically. What do you think, @arouinfar? Should we ask our PhET Fellows in Arabic-speaking Africa?

kathy-phet commented 1 year ago

@arouinfar -

arouinfar commented 1 year ago

Discussed with @kathy-phet and we decided:

@jessegreenberg @AgustinVallejo @marlitas let's update the language to "Africa (Modest)" before RC. The term may change again before publication, but a string change should be a fairly safe cherry-pick later.

marlitas commented 1 year ago

@jessegreenberg and @AgustinVallejo, let me know if you need any help or changes on the preferences side for this.

AgustinVallejo commented 1 year ago

Names have been changed!

arouinfar commented 1 year ago

Thanks @AgustinVallejo looks good. This issue no longer blocks RC testing.

Here's what it currently looks like:

image

I'll leave this self-assigned, and report back when there are updates from Sola and Zach.

zamb6873 commented 1 year ago

@arouinfar I got feedback from four PhET fellows, who all confirmed that "Africa Modest" is better than "Africa conservative."

solaolateju commented 1 year ago

Hi, @arouinfar works with most people. It is popular across the fashion industry, religion, and geography.

arouinfar commented 1 year ago

Thanks @zamb6873 @solaolateju! Let's proceed with "Africa (Modest)", closing.