search

phetsims / energy-skate-park

"Energy Skate Park" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
2 stars 11 forks source link

Friction and Gravity slider are not quite aligned #364

Closed samreid closed 1 year ago

samreid commented 1 year ago

During QA test https://github.com/phetsims/qa/issues/870, while testing https://phet-dev.colorado.edu/html/energy-skate-park/1.2.0-rc.1/phet/energy-skate-park_all_phet.html, I observed that the Friction and Gravity sliders are almost but not quite aligned. Same with the mass slider. I'm not sure if this is easy to fix or not

image

Testing on MacOS 13.0.1 on Chrome 108.0.5359.124.

arouinfar commented 1 year ago

Good find @samreid! The alignment looks correct in latest, so the misalignment is a new-ish problem.

Here's latest: image

@AgustinVallejo this would be good to address for the current release.

AgustinVallejo commented 1 year ago

@arouinfar After discussing this with SR, it's likely the alignment was never intended, more like a happy accident, and that fixing this might not be worth the trouble.

I think the x position of the slider depends more on its labels, as you can see 'None' and 'Tiny' are actually aligned... image

So I'd advice to close the issue. Assigning back to you.

arouinfar commented 1 year ago

Thanks @AgustinVallejo. I agree, let's close.