Closed Nancy-Salpepi closed 9 months ago
@arouinfar I reflected the images to do the left/right orientations, so I'm wondering how serious this issue is to you.
I'll look into the character set concern separately.. it's possible I mixed someone up.
@Nancy-Salpepi I didn't notice before, but this character does in fact appear in both Asia and Oceania, and I didn't notice at all. It's possible it is intentional, so I reached out to the artwork channel.
Hopefully @arouinfar has an answer about the reflected clothing. I'm not sure how we'd address that without redrawing people, so my best guess is that we won't address it.
I confirmed that the character IS supposed to repeat in Asia and Oceania, so nothing to do there.
@amanda-phet I figured that the character in both sets was intentional. I wrote that in case the artwork was going to be changed. Thank you for confirming though!
@arouinfar I reflected the images to do the left/right orientations, so I'm wondering how serious this issue is to you.
That's also the strategy I've used for the skater artwork. In general, I don't think there's an issue with mirroring clothing patterns/features. The only exception I recall is for characters with a prosthetic leg, where we instead created specific left/right artwork.
OK. So we can close this then.
Sorry--reopening this for https://github.com/phetsims/qa/issues/1012. @arouinfar commented:
That's also the strategy I've used for the skater artwork. In general, I don't think there's an issue with mirroring clothing patterns/features. The only exception I recall is for characters with a prosthetic leg, where we instead created specific left/right artwork.
I didn't realize there were 2 characters with a prosthetic leg in this sim. The one that appears in the Africa character set has the correct artwork:
But the one that appears in the US character set doesn't:
Also, I was wondering if it is OK that we are using the same character with a prosthetic leg in the Africa character set and without the prosthetic leg in the US character set?
That's my mistake, I will redo the American guy.
While I'm in here I can also move the pocket on that one boy and a few other types of clothing that shouldn't be reflected.
OK I just updated 4 artwork files.
I think it would also make sense to delete oceania/skater5 and just use asia/skater3 in that spot, since they are essentially the same and I don't want a duplicate artwork file to maintain.
All the artwork is now integrated.
I renamed Asia's skater3 for skater5 since there was an issue with having two skater3's in Oceania (Oceania's and Asia's files). Now the previously duplicate files are all referencing asia/skater5 and the previous asia/skater5 is now called asia/skater3.
Assigning back to @amanda-phet to review.
OK I think the rearrangement is fine. The artwork all looks good to me. @Nancy-Salpepi do you want to confirm as well?
I don't know exactly which files you changed (not sure how to figure that out), but I'm guessing it is these and all looks good: -The pocket looks good on the boy in the Africa/Africa modest character sets -The design on the shirt looks good for the boy in the Asia/Oceania character sets -The prosthetic leg has been fixed for the American guy.
Yup! There was also a girl in the Latin America set. Thanks Nancy!
She looks good too! Thanks Amanda!
Looks like this is ready to cherry pick. Marking as such.
Closing since this is now cherry-picked into branch 1.3.
Reopening for RC spot check.
Characters look good in rc.2!
For https://github.com/phetsims/qa/issues/1006: This is similar to what I saw in Number Line: Distance. When a character changes direction, clothing details (ex. pocket location) get flipped. Since the characters are moving, I'm not sure how noticeable it would be to users, but thought I would let you know.
The boy in Oceania is also in the Asia character set.