search

phetsims / energy-skate-park

"Energy Skate Park" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
2 stars 11 forks source link

Designs in clothing are reflected when character changes direction #375

Closed Nancy-Salpepi closed 9 months ago

Nancy-Salpepi commented 11 months ago

For https://github.com/phetsims/qa/issues/1006: This is similar to what I saw in Number Line: Distance. When a character changes direction, clothing details (ex. pocket location) get flipped. Since the characters are moving, I'm not sure how noticeable it would be to users, but thought I would let you know.

Screenshot 2023-11-29 at 11 16 15 AM Screenshot 2023-11-29 at 11 16 46 AM

The boy in Oceania is also in the Asia character set.

Screenshot 2023-11-29 at 11 18 05 AM
amanda-phet commented 11 months ago

@arouinfar I reflected the images to do the left/right orientations, so I'm wondering how serious this issue is to you.

I'll look into the character set concern separately.. it's possible I mixed someone up.

amanda-phet commented 11 months ago

@Nancy-Salpepi I didn't notice before, but this character does in fact appear in both Asia and Oceania, and I didn't notice at all. It's possible it is intentional, so I reached out to the artwork channel.

image

Hopefully @arouinfar has an answer about the reflected clothing. I'm not sure how we'd address that without redrawing people, so my best guess is that we won't address it.

amanda-phet commented 11 months ago

I confirmed that the character IS supposed to repeat in Asia and Oceania, so nothing to do there.

Nancy-Salpepi commented 11 months ago

@amanda-phet I figured that the character in both sets was intentional. I wrote that in case the artwork was going to be changed. Thank you for confirming though!

arouinfar commented 11 months ago

@arouinfar I reflected the images to do the left/right orientations, so I'm wondering how serious this issue is to you.

That's also the strategy I've used for the skater artwork. In general, I don't think there's an issue with mirroring clothing patterns/features. The only exception I recall is for characters with a prosthetic leg, where we instead created specific left/right artwork.

Nancy-Salpepi commented 11 months ago

OK. So we can close this then.

Nancy-Salpepi commented 10 months ago

Sorry--reopening this for https://github.com/phetsims/qa/issues/1012. @arouinfar commented:

That's also the strategy I've used for the skater artwork. In general, I don't think there's an issue with mirroring clothing patterns/features. The only exception I recall is for characters with a prosthetic leg, where we instead created specific left/right artwork.

I didn't realize there were 2 characters with a prosthetic leg in this sim. The one that appears in the Africa character set has the correct artwork:

Screenshot 2023-12-13 at 10 20 37 AM

But the one that appears in the US character set doesn't:

Screenshot 2023-12-13 at 10 21 14 AM
Nancy-Salpepi commented 10 months ago

Also, I was wondering if it is OK that we are using the same character with a prosthetic leg in the Africa character set and without the prosthetic leg in the US character set?

Screenshot 2023-12-13 at 3 58 15 PM Screenshot 2023-12-13 at 3 58 39 PM
amanda-phet commented 10 months ago

That's my mistake, I will redo the American guy.

While I'm in here I can also move the pocket on that one boy and a few other types of clothing that shouldn't be reflected.

amanda-phet commented 10 months ago

OK I just updated 4 artwork files.

I think it would also make sense to delete oceania/skater5 and just use asia/skater3 in that spot, since they are essentially the same and I don't want a duplicate artwork file to maintain.

Luisav1 commented 10 months ago

All the artwork is now integrated.

I renamed Asia's skater3 for skater5 since there was an issue with having two skater3's in Oceania (Oceania's and Asia's files). Now the previously duplicate files are all referencing asia/skater5 and the previous asia/skater5 is now called asia/skater3.

Assigning back to @amanda-phet to review.

amanda-phet commented 10 months ago

OK I think the rearrangement is fine. The artwork all looks good to me. @Nancy-Salpepi do you want to confirm as well?

Nancy-Salpepi commented 10 months ago

I don't know exactly which files you changed (not sure how to figure that out), but I'm guessing it is these and all looks good: -The pocket looks good on the boy in the Africa/Africa modest character sets -The design on the shirt looks good for the boy in the Asia/Oceania character sets -The prosthetic leg has been fixed for the American guy.

amanda-phet commented 10 months ago

Yup! There was also a girl in the Latin America set. Thanks Nancy!

Nancy-Salpepi commented 10 months ago

She looks good too! Thanks Amanda!

marlitas commented 10 months ago

Looks like this is ready to cherry pick. Marking as such.

Luisav1 commented 10 months ago

Closing since this is now cherry-picked into branch 1.3.

Luisav1 commented 10 months ago

Reopening for RC spot check.

Nancy-Salpepi commented 9 months ago

Characters look good in rc.2!