phetsims / equality-explorer

"Equality Explorer" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 3 forks source link

Add support for PhET-iO #151

Closed pixelzoom closed 2 years ago

pixelzoom commented 5 years ago

Things to consider when this sim is instrumented for PhET-iO.

EqualityExplorerMovable defines isDisposed and dispose. If it needs to extend PhetioObject, these definitions will shadow definitions in PhetioObject.

pixelzoom commented 3 years ago

@kathy-phet asked for an estimate to add PhET-iO instrumentation. Here it is:

It’s difficult to provide an estimate without knowing the PhET-iO requirements. But assuming that we instrument all 3 sims in this family, and assuming there’s nothing ununsual like the special query parameters in Natural Selection.. My estimate is 200-300 hours.

Here’s how I arrived at that estimate:

pixelzoom commented 2 years ago

My understanding is that @kathy-phet would like to discuss this sometime towards the beginning of Q2 2022. So assigning to @kathy-phet and @amanda-phet.

pixelzoom commented 2 years ago

As we did with Natural Selection, the first phase of adding PhET-iO support needs to be design. Identify sim-specific features, provide as much information as possible to make sure that PhET-iO instrumentation is done in a way that it can support those features.

EDIT: PhET-iO design is being tracked in https://github.com/phetsims/equality-explorer/issues/191

pixelzoom commented 2 years ago

According to @kathy-phet in Slack, "we are going to postpone that work on EE for now". So unassigning myself, and labeling as deferred.

pixelzoom commented 2 years ago

@kathy-phet would like me to do the "basic" PhET-iO instrumentation for this sim; no custom IOTypes or dynamic elements, just the stuff that is straightforward. I did a little bit of that as part of TypeScript conversion #186, since some of PhET’s APIs now require tandems when used with TypeScript. This will also get me more familiar with the things that are going to be more difficult, and I'll try to note those things in this issue as I go.

pixelzoom commented 2 years ago

Basic PhET-iO instrumentation is being done as part of https://github.com/phetsims/equality-explorer/issues/192.

pixelzoom commented 2 years ago

Doing this work in https://github.com/phetsims/equality-explorer/issues/192, per the "process". Closing.