search

phetsims / equality-explorer

"Equality Explorer" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 3 forks source link

Levels that are not included in ?gameLevels should not be shown in game Info dialog. #184

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

Related to https://github.com/phetsims/vegas/issues/104

pixelzoom commented 2 years ago

On hold until general design decisions have been made, see https://github.com/phetsims/vegas/issues/104#issuecomment-1102871139.

pixelzoom commented 2 years ago

In https://github.com/phetsims/vegas/issues/104#issuecomment-1119190311, @amanda-phet said:

That sounds great to do this for EqEx.

pixelzoom commented 2 years ago

@amanda-phet please review in master. For example, test with ?gameLevels=1,3,5 and verify that the correct level-selection buttons and level descriptions (in the Info dialog) are shown.

pixelzoom commented 2 years ago

In Slack, @amanda-phet asked:

Are you moving forward with the option that only shows the relevant levels and hides the others? Or the option that shows all levels, but “grays out” (text is gray, not black) the levels that aren’t options on the level selection screen?

Only show info for relevant levels, similar to how level-selection buttons are treated.

amanda-phet commented 2 years ago

Looks great to me!