search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Pointer areas #100

Closed jonathanolson closed 7 years ago

jonathanolson commented 7 years ago

Very few are overridden. Has the sim been vetted for what touch areas should be expanded?

Code review from https://github.com/phetsims/expression-exchange/issues/88

jbphet commented 7 years ago

I made some minor adjustments, and tested on iPad 2, and it all feels pretty usable to me. Assigning to @phet-steele for verification on upcoming dev release.

amanda-phet commented 7 years ago

1 and -1 look funny on the Negatives screen.

Also, I know that with a toggle you can generally click the images next to the toggle instead of dragging the actual toggle knob. I don't see the touch areas outlined with the query parameter but I can check on an iPad to see that they are functioning ok.

amanda-phet commented 7 years ago

Confirmed with iPad that the touch areas for the toggle are not large enough (or existent?). Can we make sure that the images for the coin and x are comfortably large for touch?

Currently, only the toggle knob has a larger touch area: screen shot 2017-06-22 at 1 53 31 pm

jbphet commented 7 years ago

As for 1 and -1, I think @amanda-phet was seeing the pointer areas for items that were clipped from the carousel. I went ahead and added pointer areas to the constant coin terms though, just to avoid confusion, and it might make them more consistent to interact with.

As for the AB switch, I've expanded the touch areas for the nodes used and shifted these touch areas so that they don't overlap with that of the switch, here's a screenshot with showPointerAreas turned on.

exex-touch

Back to you @amanda-phet.

phet-steele commented 7 years ago

@amanda-phet likes the touch areas in dev.4, and so do I.