search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Cut buttons should disappear when clicking away #125

Open samreid opened 7 years ago

samreid commented 7 years ago

While working on https://github.com/phetsims/circuit-construction-kit-dc/issues/87 @jonathanolson and I noticed that the cut button is on a timer. That seems like an accessibility problem, since some users will not be able to reach the button within the allotted time. In other sims such as CCK we have used a pattern where clicking away, or clicking anything else dismisses the scissor buttons.

@jonathanolson and I are working on an approach in Scenery to make this easier.

jonathanolson commented 7 years ago

Mentioned approach is in https://github.com/phetsims/scenery/issues/650.

Would add phet.joist.sim.display.addInputListener( ... ) with a listener that dismisses the buttons when the user clicks outside of the Expression or buttons themselves.

jbphet commented 7 years ago

Assigning to @amanda-phet to decide if the behavior should be changed in the recommended way. I have no objection.

amanda-phet commented 7 years ago

I can't remember exactly why we chose the timer... I just know that we wanted the buttons to go away. Clicking away seems reasonable.

To clarify, the behavior here won't mimic CCK in other ways- for example, unlike CCK, the rearrange and scissor buttons should appear while dragging and persist after stopping a drag (until they click away).