search

phetsims / expression-exchange

"Expression Exchange" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

remove Tween preload? #140

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

I don't see TWEEN used anywhere in expression-exchange or its dependencies, but I see this preload in package.json:

    "preload": [
      "../sherpa/lib/Tween-r12.js"
    ]

Can this preload be removed?

jbphet commented 5 years ago

Yes indeed, it can be. I've removed it and regenerated the HTML, and also removed a comment that referenced TWEEN and was no longer correct. I must've missed this items when working on #137, so it's good this was caught. I'm just going to close this issue, but @pixelzoom you're welcome to review if you think it's necessary when you see the GitHub notification go by.

jbphet commented 5 years ago

BTW, I tested both the RequireJS and built versions after making the changes described above.