Open samreid opened 1 year ago
I tested the behavior in the master version of the sim and it seems fine, but I agree that the fix is a bit brittle (and, admittedly, the original code was too). I for one would not object to the carousel changing size as the things inside of it change, but that's a design decision, and it doesn't seem like it is worth spending time on at the moment. I'll unassign this issue and will mark it as blocking sim publication, and we will revisit this the next time it is published from master.
FWIW, another possible solution might be to use a transparent container node of a fixed size to hold the items in the carousel and limit the items to fit within it.
Related to https://github.com/phetsims/sun/issues/814 and #159, @jonathanolson said:
I replied:
Summarizing the problem and my main concerns:
I figure we can do any necessary fine-tuning when we revisit this sim for publication, but I want to leave it in a reasonable state in the meantime, so I wanted to reach out to @jbphet for assistance when there's time.